Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for async reset regs of non-UInt types #1414

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Add tests for async reset regs of non-UInt types #1414

merged 1 commit into from
Apr 16, 2020

Conversation

jackkoenig
Copy link
Contributor

Add some tests that would've caught an embarrassing bug

Will fail until chipsalliance/firrtl#1523 is merged

Marked for backport, will fail because of Intervals, I'll fixup manually.

Related issue:

Type of change: add tests

Impact: no functional change

Development Phase: implementation

Release Notes

@jackkoenig jackkoenig added this to the 3.2.X milestone Apr 14, 2020
@jackkoenig jackkoenig requested a review from a team as a code owner April 14, 2020 03:32
ucbjrl
ucbjrl approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@ucbjrl ucbjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Apr 16, 2020
@mergify mergify bot merged commit e6c179a into master Apr 16, 2020
mergify bot pushed a commit that referenced this pull request Apr 16, 2020
@jackkoenig
Add tests for async reset regs of non-UInt types (#1414)
78db945 
(cherry picked from commit e6c179a)
@mergify mergify bot mentioned this pull request Apr 16, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported label Apr 16, 2020
@jackkoenig jackkoenig deleted the more-async-reset-tests branch April 16, 2020 22:48
mergify bot added a commit that referenced this pull request Apr 27, 2020
@mergify @jackkoenig
Add tests for async reset regs of non-UInt types (bp #1414) (#1416)
5dc09e7 
* Add tests for async reset regs of non-UInt types (#1414)


(cherry picked from commit e6c179a)

* Remove Intervals from AsyncReset tests for 3.2.x

Co-authored-by: Jack Koenig <koenig@sifive.com>
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@albert-magyar
Update single-line when/else example in spec to match implementation (#…
c37690f 
…1414)

* Closes #890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardcwang edwardcwang edwardcwang approved these changes

@ucbjrl ucbjrl ucbjrl approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jackkoenig @ucbjrl @edwardcwang